jackwener commented on code in PR #4650: URL: https://github.com/apache/arrow-datafusion/pull/4650#discussion_r1052731724
########## benchmarks/expected-plans/q20.txt: ########## @@ -1,17 +1,17 @@ Sort: supplier.s_name ASC NULLS LAST Projection: supplier.s_name, supplier.s_address - LeftSemi Join: supplier.s_suppkey = __sq_2.ps_suppkey + LeftSemi Join: supplier.s_suppkey = __sq_1.ps_suppkey Review Comment: 😂 original implementation mix `TopDown` and `BottomUp`. It use `TopDown` overall, but use `BottomUp` when match the subPlan. I think it's a small mistake in original code but don't affect correctness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
