mingmwang commented on issue #4617: URL: https://github.com/apache/arrow-datafusion/issues/4617#issuecomment-1358783170
The changes LGTM except for https://github.com/apache/arrow-datafusion/pull/4633. And I have a feeling that `ExecutionProps` should be moved out from the `SessionState`, so that most of the time, `SessionState` is immutable. `ExecutionProps` should be related to a specific query statement/DataFrame, it lives much shorter that a Session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
