tustvold commented on code in PR #3374:
URL: https://github.com/apache/arrow-rs/pull/3374#discussion_r1053107539
##########
parquet/src/file/writer.rs:
##########
@@ -326,7 +324,6 @@ impl<W: Write> SerializedFileWriter<W> {
{
let mut protocol = TCompactOutputProtocol::new(&mut self.buf);
file_metadata.write_to_out_protocol(&mut protocol)?;
- protocol.flush()?;
Review Comment:
Is there some need to flush the protocol before drop, or does this simply
flush the inner writer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
