alamb commented on code in PR #3375:
URL: https://github.com/apache/arrow-rs/pull/3375#discussion_r1053608035
##########
arrow-array/src/lib.rs:
##########
@@ -183,6 +183,25 @@ pub mod timezone;
mod trusted_len;
pub mod types;
+/// Options that define how sort kernels should behave
Review Comment:
Maybe it could even be put in arrow_schema
##########
arrow-ord/src/sort.rs:
##########
@@ -27,6 +27,8 @@ use arrow_schema::{ArrowError, DataType, IntervalUnit,
TimeUnit};
use arrow_select::take::take;
use std::cmp::Ordering;
+pub use arrow_array::SortOptions;
Review Comment:
👍 for backward compatibility
##########
dev/release/README.md:
##########
@@ -258,13 +258,12 @@ Rust Arrow Crates:
(cd arrow-array && cargo publish)
(cd arrow-select && cargo publish)
(cd arrow-cast && cargo publish)
-(cd arrow-string && cargo publish)
Review Comment:
Thanks -- I'll test them out on the next release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
