andre-cc-natzka commented on code in PR #4682:
URL: https://github.com/apache/arrow-datafusion/pull/4682#discussion_r1054099585
##########
datafusion/optimizer/src/utils.rs:
##########
@@ -583,6 +583,7 @@ where
fn name_for_alias(expr: &Expr) -> Result<String> {
match expr {
Expr::Sort { expr, .. } => name_for_alias(expr),
+ Expr::Wildcard => Ok("*".to_string()),
expr => expr.display_name(),
Review Comment:
Thank you very much @alamb! I agree with you, so I've just moved that line
to the `create_name` function called by `Expr::display_name`. If this is fine
for you, I guess we can merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
