mustafasrepo commented on code in PR #4675:
URL: https://github.com/apache/arrow-datafusion/pull/4675#discussion_r1055152398
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -220,7 +220,7 @@ impl FileFormat for ParquetFormat {
}
fn summarize_min_max(
- max_values: &mut [Option<MaxAccumulator>],
+ max_values: &mut [Option<SlidingMaxAccumulator>],
Review Comment:
> Other than the changes in
`datafusion/core/src/datasource/file_format/parquet.rs` and
`datafusion/core/src/datasource/mod.rs` I think this PR looks ready to go.
>
> Thank you for your work on it
These changes introduced during Struct renaming by IDE, I missed these
changes. Thanks for pointing it out. I have reverted these changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
