rtpsw commented on PR #14799: URL: https://github.com/apache/arrow/pull/14799#issuecomment-1362641280
The [recent commit](https://github.com/apache/arrow/pull/14799/commits/c19a2bddb1b8fcaec4a443df56021c3d5348dd91) fixed the ASAN failure by avoiding a null executor, so that the `AsofJoinNode` destructor is never called from the process-thread. It also includes a [fix in `exec_plan.cc`](https://github.com/apache/arrow/pull/14799/commits/c19a2bddb1b8fcaec4a443df56021c3d5348dd91#diff-5789a42aebc3bd0f5a6db687c78ab0c3eef3e316982f99fe9e0ea21fabed354cR1042-R1044) that avoids hanging tasks when a later one fails to initialize. I observed such a condition when the source nodes hanged when the as-of-join node failed (as expected in some test case) to initialize with a null executor. Note that accepting this commit would cause any code out there that uses as-of-join with a null executor (as in the current default exec context) to fail. My understanding is that the API is experimental right now, so it should be OK to break for a good reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
