domoritz commented on issue #14973:
URL: https://github.com/apache/arrow/issues/14973#issuecomment-1363114103

   I am not fully following the proposal. `toString` can produce strings that 
are not JSON and I think that's okay. This looks good to me actually
   
   ```js
   const tableAsArray = tableFromIPC(someSource).toArray();
   
   console.log(tableAsArray);
   // [{ id: 'foo', name: 'bar', dob: Fri Dec 15 2000 12:00:00 GMT+0100 
(Central European Standard Time) }]
   ```
   
   But it would probably make sense to make it consistent with 
   
   ```js
   const tableAsString = tableFromIPC(someSource).toString();
   
   console.log(tableAsString);
   // '[{"id":"foo","name":"bar","dob":Fri Dec 15 2000 12:00:00 GMT+0100 
(Central European Standard Time)}]'
   ```
   
   `toJSON` has the challenge that we use it to produce js objects rather than 
actual JSON strings (for performance reasons and we can consider alternatives). 
But we should expect `JSON.stringify(X.toJSON())` to work and if it doesn't I 
would consider that a bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to