EpsilonPrime commented on code in PR #15063:
URL: https://github.com/apache/arrow/pull/15063#discussion_r1055863593
##########
cpp/src/arrow/engine/substrait/extension_set.cc:
##########
@@ -706,11 +706,11 @@ class EnumParser {
};
enum class TemporalComponent { kUnspecified = 0, kYear, kMonth, kDay, kSecond
};
-static std::vector<std::string> kTemporalComponentOptions = {"YEAR", "MONTH",
"DAY",
- "SECOND"};
+static std::vector<std::string> kTemporalComponentOptions = {"UNSPECIFIED",
"YEAR",
+ "MONTH", "DAY",
"SECOND"};
Review Comment:
Removing that parse extra parse check yields a rather useful "The value
BOGUS is not an expected enum value" message when the value can't be parsed so
I've removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
