westonpace commented on PR #14867: URL: https://github.com/apache/arrow/pull/14867#issuecomment-1364092173
@rtpsw https://github.com/apache/arrow/commit/0f2b458ec45c851707bf8f6f93e0e703af359f26 is an example of layering this PR on top of your ordered groupby changes. I couldn't get the aggregate node working because I don't think it works at the moment and didn't want to dive too deep into that problem just yet. However, I don't see any reason your ordered aggregation won't work with this PR. Also, once things are working, we should be able to go further and: * remove chunked array from datum * remove all grouper.cc/grouper.h changes which use spans and instead only use batches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
