rtpsw commented on code in PR #14352:
URL: https://github.com/apache/arrow/pull/14352#discussion_r1056638346
##########
cpp/src/arrow/compute/row/grouper.h:
##########
@@ -39,10 +77,19 @@ class ARROW_EXPORT Grouper {
static Result<std::unique_ptr<Grouper>> Make(const std::vector<TypeHolder>&
key_types,
ExecContext* ctx =
default_exec_context());
- /// Consume a batch of keys, producing the corresponding group ids as an
integer array.
+ /// Consume a batch of keys, producing the corresponding group ids as an
integer array,
+ /// over a slice defined by an offset and length, which defaults to the
batch length.
+ /// Currently only uint32 indices will be produced, eventually the bit width
will only
+ /// be as wide as necessary.
Review Comment:
This is copied from an [existing
comment](https://github.com/apache/arrow/pull/14352/files#diff-f4d905573735385f5e4030a5f22e7653cf0fa379ef192ced676f59c2f7eebb4cR89-R90)
of a method by the same name. I don't mind removing it if you still think it
should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
