alamb commented on code in PR #4722:
URL: https://github.com/apache/arrow-datafusion/pull/4722#discussion_r1056681646


##########
datafusion/core/tests/sql/information_schema.rs:
##########
@@ -30,91 +30,6 @@ use rstest::rstest;
 
 use super::*;
 
-#[tokio::test]

Review Comment:
   I ported a few tests over to show the behavior -- I will port what else I 
can from this file as a follow on PR



##########
datafusion/core/tests/sqllogictests/src/main.rs:
##########
@@ -130,12 +130,6 @@ async fn context_for_test_file(file_name: &str) -> 
SessionContext {
             setup::register_aggregate_tables(&ctx).await;
             ctx
         }
-        "information_schema.slt" => {

Review Comment:
   since this is now controllable dynamically, we do not have to hard code the 
sqltest runner



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to