ygf11 opened a new pull request, #4725:
URL: https://github.com/apache/arrow-datafusion/pull/4725

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #4724.
   
   # Rationale for this change
   
   Currently datafusion support rewrite in-subquery to join when the expression 
is a column, like:
   ```sql
   > select * from t1 where t1_id in (select t2_id from t2);
   ```
   but following sql does not works:
   ```sql
   > select * from t1 where t1_id + 11 in (select t2_id from t2);
   NotImplemented("Physical plan does not support logical expression 
CAST(t1.t1_id AS Int64) + Int64(11) IN (<subquery>)")
   ```
   
   We can rewrite these subquery to join also.
   
   # What changes are included in this PR?
   In `SubqueryFilterToJoin`:
   1. Rewrite `where x+1 in (...)` to equi-join.
   2. Rewrite `where 1 in (..)` to non equi-join.
   
   # Are these changes tested?
   Yes
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to