heronshoes opened a new pull request, #15088:
URL: https://github.com/apache/arrow/pull/15088

   ### What I did
   
   * Add support for `keys = nil` in `Table#join`
     * When `keys.nil?` common keys in self and right will automatically set to 
keys.
   * Add assertions without argument keys.
   * Add missing comments for other oveload cases.
   
   ### What I did'nt
   
   * May be a little bit sorter if #column_names has introduced.
   
   ### What I checked
   
   * It works the same way in RedAmber.
   
   ### Notes for reviewers
   
   * This is my first PR on Arrow using the new GitHub-only scheme. If you can 
point out anything I'm missing, I'd appreciate it.
   
   ### Related Issue
   
   * Github Issue #15084 .
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to