waynexia opened a new pull request, #4733:
URL: https://github.com/apache/arrow-datafusion/pull/4733
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #4575 .
# Rationale for this change
`common_subexpression_eliminate` optimizer doesn't consider the situation
that some plans (like `Sort` or `Filter`) rely on the input's schema. When
introducing an intermediate projection schema that evaluates the common
expressions, it also changes the "input schema" for those optimized plans. This
patch will check if the output schema changed, and add another projection to
recover the output schema if so.
# What changes are included in this PR?
Except the extra projection described above, this patch also fixes the
problem that the optimizer used to build `Projection` plan manually, rather
than through `Projection::try_new()` constructor. This will bypass the schema
check process and may produce a wrong projection plan, whose schema doesn't
match its exprs.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, add a new case `filter_schema_changed` to cover
# Are there any user-facing changes?
no
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
