alamb commented on code in PR #4713:
URL: https://github.com/apache/arrow-datafusion/pull/4713#discussion_r1057251863
##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -126,14 +127,18 @@ impl ParquetExec {
}
}
})
- .and_then(|pruning_predicate| {
- // If the pruning predicate can't prune anything, don't try
- if pruning_predicate.allways_true() {
+ .filter(|p| !p.allways_true());
+
+ let page_pruning_predicate =
predicate.as_ref().and_then(|predicate_expr| {
+ match PagePruningPredicate::try_new(predicate_expr,
file_schema.clone()) {
+ Ok(pruning_predicate) => Some(Arc::new(pruning_predicate)),
+ Err(e) => {
+ debug!("Could not create page pruning predicate for: {}",
e);
Review Comment:
Proposed change in https://github.com/apache/arrow-datafusion/pull/4736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
