westonpace commented on code in PR #13848:
URL: https://github.com/apache/arrow/pull/13848#discussion_r1057275277
##########
cpp/src/arrow/compute/exec/exec_plan.h:
##########
@@ -328,27 +316,14 @@ class ARROW_EXPORT ExecNode {
/// This may be called any number of times after StartProducing() succeeds.
virtual void ResumeProducing(ExecNode* output, int32_t counter) = 0;
- /// \brief Stop producing definitively to a single output
- ///
- /// This call is a hint that an output node has completed and is not willing
- /// to receive any further data.
- virtual void StopProducing(ExecNode* output) = 0;
Review Comment:
I've since learned that this is still needed. This covers the case where a
LIMIT X node is placed on one branch of a query. It is intended to stop part
of the plan but not abort the entire plan. Do you think we can leave it in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
