kou commented on code in PR #15089:
URL: https://github.com/apache/arrow/pull/15089#discussion_r1057394188
##########
ruby/red-arrow/lib/arrow/column-containable.rb:
##########
@@ -143,5 +143,14 @@ def [](selector)
find_column(selector)
end
end
+
+ # Return column names in this table.
Review Comment:
```suggestion
# Return column names in this object.
```
##########
ruby/red-arrow/test/test-table.rb:
##########
@@ -602,6 +602,18 @@ def setup
end
end
+ sub_test_case("#column_names") do
+ test ("unique") do
Review Comment:
```suggestion
test("unique") do
```
##########
ruby/red-arrow/test/test-table.rb:
##########
@@ -602,6 +602,18 @@ def setup
end
end
+ sub_test_case("#column_names") do
+ test ("unique") do
Review Comment:
```suggestion
test("unique") do
```
##########
ruby/red-arrow/test/test-table.rb:
##########
@@ -602,6 +602,18 @@ def setup
end
end
+ sub_test_case("#column_names") do
+ test ("unique") do
+ table = Arrow::Table.new(a: [1], b: [2], c: [3])
+ assert_equal(%w[a b c], table.column_names)
+ end
+
+ test ("duplicated") do
Review Comment:
```suggestion
test("duplicated") do
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
