ygf11 commented on code in PR #4755:
URL: https://github.com/apache/arrow-datafusion/pull/4755#discussion_r1058178957
##########
datafusion/core/tests/sql/joins.rs:
##########
@@ -2452,29 +2452,29 @@ async fn both_side_expr_key_inner_join() -> Result<()> {
"ProjectionExec: expr=[t1_id@0 as t1_id, t2_id@2 as t2_id,
t1_name@1 as t1_name]",
" ProjectionExec: expr=[t1_id@0 as t1_id, t1_name@1 as
t1_name, t2_id@3 as t2_id]",
" CoalesceBatchesExec: target_batch_size=4096",
- " HashJoinExec: mode=Partitioned, join_type=Inner,
on=[(Column { name: \"t1.t1_id + Int64(12)\", index: 2 }, Column { name:
\"t2.t2_id + Int64(1)\", index: 1 })]",
+ " HashJoinExec: mode=Partitioned, join_type=Inner,
on=[(Column { name: \"t1.t1_id + UInt32(12)\", index: 2 }, Column { name:
\"t2.t2_id + UInt32(1)\", index: 1 })]",
" CoalesceBatchesExec: target_batch_size=4096",
- " RepartitionExec: partitioning=Hash([Column { name:
\"t1.t1_id + Int64(12)\", index: 2 }], 2)",
- " ProjectionExec: expr=[t1_id@0 as t1_id, t1_name@1
as t1_name, t1_id@0 + CAST(12 AS UInt32) as t1.t1_id + Int64(12)]",
+ " RepartitionExec: partitioning=Hash([Column { name:
\"t1.t1_id + UInt32(12)\", index: 2 }], 2)",
+ " ProjectionExec: expr=[t1_id@0 as t1_id, t1_name@1
as t1_name, t1_id@0 + 12 as t1.t1_id + UInt32(12)]",
" RepartitionExec:
partitioning=RoundRobinBatch(2)",
" MemoryExec: partitions=1,
partition_sizes=[1]",
" CoalesceBatchesExec: target_batch_size=4096",
- " RepartitionExec: partitioning=Hash([Column { name:
\"t2.t2_id + Int64(1)\", index: 1 }], 2)",
- " ProjectionExec: expr=[t2_id@0 as t2_id, t2_id@0 +
CAST(1 AS UInt32) as t2.t2_id + Int64(1)]",
+ " RepartitionExec: partitioning=Hash([Column { name:
\"t2.t2_id + UInt32(1)\", index: 1 }], 2)",
+ " ProjectionExec: expr=[t2_id@0 as t2_id, t2_id@0 +
1 as t2.t2_id + UInt32(1)]",
" RepartitionExec:
partitioning=RoundRobinBatch(2)",
" MemoryExec: partitions=1,
partition_sizes=[1]",
Review Comment:
The `SimplifyExpressions` rule failed in this test case before, take effect
now.
Other test cases modified in this pr also take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
