assignUser commented on code in PR #15076: URL: https://github.com/apache/arrow/pull/15076#discussion_r1058384847
########## r/.Rbuildignore: ########## @@ -31,3 +31,4 @@ STYLE.md ^revdep$ ^vignettes$ ^PACKAGING\.md$ +^__pycache__$ Review Comment: The path has needs to be relative to the root dir. ```suggestion ^inst/__pycache__$ ``` ########## r/.Rbuildignore: ########## @@ -31,3 +31,4 @@ STYLE.md ^revdep$ ^vignettes$ ^PACKAGING\.md$ +^__pycache__$ Review Comment: (or alternatively we need to remove the line start/end markers `^ $` to ignore pycache dirs regardless of location in the package. I prefer the more explicit version above though. ########## r/.Rbuildignore: ########## @@ -31,3 +31,4 @@ STYLE.md ^revdep$ ^vignettes$ ^PACKAGING\.md$ +^__pycache__$ Review Comment: (or alternatively we need to remove the line start/end markers `^ $` to ignore pycache dirs regardless of location in the package. I prefer the more explicit version above though. ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
