tustvold opened a new pull request, #4767: URL: https://github.com/apache/arrow-datafusion/pull/4767
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #3437 Closes #3791 (although these were actually fixed by https://github.com/apache/arrow-datafusion/pull/4038) # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Having mutable state associated with `OptimizerConfig` complicates implementing it for `SessionState`. I originally hoped to implement `OptimizerConfig` for `DataFrame`, but this would have required churning all the planning machinery and so I decided against this. There is one implication potentially worth highlighting with this change, as the state is now associated with the `OptimizerRule` and not an `OptimizerContext` created for the call to `SessionState::optimize`, state will now bleed across calls whereas it previously wouldn't. In some ways this is better, as previously calling `optimize` twice could theoretically result in an alias collision, but I thought it worth highlighting. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Move alias state from `OptimizerConfig` onto the individual rules # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? Yes, queries will get potentially different aliases assigned to them by the optimizer. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
