alamb commented on PR #3391:
URL: https://github.com/apache/arrow-rs/pull/3391#issuecomment-1367371045

   > Mostly just some minor nits, I personally would avoid upstreaming the 
hydration of dictionaries so that we aren't committed to supporting it long term
   
   
   I have pondered this for a while and my plan is to proceed with merging this 
PR (with the temporary dictionary hydration) and work on proper dictionary 
support as a follow on PR for the following reasons:
   
   1. I want to make sure that the rust dictionary handling is correct and for 
that I would like to use the existing flight integration tests but they need 
work to update them to the new client too
   2. I have one [PR](https://github.com/apache/arrow-rs/pull/3402) (and about 
to be more than one) queued up waiting on this PR
   
   In order to minimize the API churn however, I plan to hold this PR until 
after we have released 30.0.0 (#3336 ) so we can minimize the chance of 
releasing the dictionary hydration code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to