lidavidm commented on code in PR #15106:
URL: https://github.com/apache/arrow/pull/15106#discussion_r1059137762
##########
java/algorithm/src/main/java/org/apache/arrow/algorithm/sort/VectorValueComparator.java:
##########
@@ -76,6 +88,10 @@ public void attachVector(V vector) {
public void attachVectors(V vector1, V vector2) {
this.vector1 = vector1;
this.vector2 = vector2;
+
+ final boolean v1MayHaveNulls =
vector1.getField().getFieldType().isNullable();
+ final boolean v2MayHaveNulls =
vector2.getField().getFieldType().isNullable();
Review Comment:
Ah, that's what I wasn't remembering. In that case, the right check might be
to see if the buffer length is 0 (in which case there can't be any nulls)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
