rdettai commented on a change in pull request #8525:
URL: https://github.com/apache/arrow/pull/8525#discussion_r513243215



##########
File path: rust/parquet/src/file/reader.rs
##########
@@ -32,6 +32,22 @@ use crate::basic::Type;
 
 use crate::column::reader::ColumnReaderImpl;
 
+/// Parquet files must be read from end for the footer then from start for 
columns
+pub enum ChunkMode {

Review comment:
       `std::io::SeekFrom` is similar but it has also the `SeekFrom::Current` 
state that we are not interested in. 
   About the name, I agree that `ChunkMode` is not ideal, but I wanted it to 
explicitly relate to ChunkReader. What about the more verbose but probably also 
more explicit `ReadChunkFrom` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to