viirya commented on code in PR #3421: URL: https://github.com/apache/arrow-rs/pull/3421#discussion_r1059669109
########## arrow-ipc/src/lib.rs: ########## @@ -15,10 +15,7 @@ // specific language governing permissions and limitations // under the License. -//! Support for the Arrow IPC format - -// TODO: (vcq): Protobuf codegen is not generating Debug impls. -#![allow(missing_debug_implementations)] +//! Support for the [Arrow IPC Format](https://arrow.apache.org/docs/format/IPC.html) Review Comment: Actually this page was moved. Maybe we can point to https://arrow.apache.org/docs/format/Columnar.html#format-columnar, or https://arrow.apache.org/docs/format/Columnar.html#serialization-and-interprocess-communication-ipc specifically? ########## arrow-ipc/src/writer.rs: ########## @@ -137,6 +137,34 @@ impl Default for IpcWriteOptions { } #[derive(Debug, Default)] +/// Handles low level details of encoding [`Array`] and [`Schema`] into the +/// [Arrow IPC Format](https://arrow.apache.org/docs/format/IPC.html) Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
