alamb commented on issue #4786: URL: https://github.com/apache/arrow-datafusion/issues/4786#issuecomment-1368445057
Prior to the fixes for https://github.com/apache/arrow-datafusion/issues/4065 these queries would overflow the stack during SQL planning After the fixes for https://github.com/apache/arrow-datafusion/issues/4065 the overflow in the `push_down_filter` pass You can see what the problem is by running under lldb: ```shell $ RUST_MIN_STACK=1000000 rust-lldb /Users/alamb/Software/target-df2/debug/deps/tpcds_planning-c781740f1011efdc ... (lldb) type category enable Rust (lldb) target create "/Users/alamb/Software/target-df2/debug/deps/tpcds_planning-c781740f1011efdc" Current executable set to '/Users/alamb/Software/target-df2/debug/deps/tpcds_planning-c781740f1011efdc' (x86_64). (lldb) r Process 93091 launched: '/Users/alamb/Software/target-df2/debug/deps/tpcds_planning-c781740f1011efdc' (x86_64) running 198 tests test tpcds_logical_q22 ... ok Process 93091 stopped * thread #2, name = 'tpcds_logical_q1', stop reason = EXC_BAD_ACCESS (code=2, address=0x70000488f3a8) frame #0: 0x000000010399f23e tpcds_planning-c781740f1011efdc`__rust_probestack + 23 tpcds_planning-c781740f1011efdc`: -> 0x10399f23e <+23>: testq %rsp, 0x8(%rsp) 0x10399f243 <+28>: subq $0x1000, %r11 ; imm = 0x1000 0x10399f24a <+35>: cmpq $0x1000, %r11 ; imm = 0x1000 0x10399f251 <+42>: ja 0x10399f237 ; <+16> Target 0: (tpcds_planning-c781740f1011efdc) stopped. (lldb) bt * thread #2, name = 'tpcds_logical_q1', stop reason = EXC_BAD_ACCESS (code=2, address=0x70000488f3a8) * frame #0: 0x000000010399f23e tpcds_planning-c781740f1011efdc`__rust_probestack + 23 frame #1: 0x000000010106b50e tpcds_planning-c781740f1011efdc`_$LT$datafusion_expr..expr..Expr$u20$as$u20$datafusion_expr..expr_rewriter..ExprRewritable$GT$::rewrite::h980731ca505c0427 at expr_rewriter.rs:101 frame #2: 0x000000010103b165 tpcds_planning-c781740f1011efdc`datafusion_expr::expr_rewriter::rewrite_boxed::haff2d36daa5dd0d6 at expr_rewriter.rs:312:26 frame #3: 0x000000010106bd0c tpcds_planning-c781740f1011efdc`_$LT$datafusion_expr..expr..Expr$u20$as$u20$datafusion_expr..expr_rewriter..ExprRewritable$GT$::rewrite::h980731ca505c0427 at expr_rewriter.rs:131:21 frame #4: 0x00000001010b3021 tpcds_planning-c781740f1011efdc`datafusion_expr::utils::from_plan::he7efef4d1b95ebfa at utils.rs:523:29 frame #5: 0x00000001007055ae tpcds_planning-c781740f1011efdc`datafusion_optimizer::utils::optimize_children::h54aa06b4ed6a900f at utils.rs:51:5 frame #6: 0x00000001006bf761 tpcds_planning-c781740f1011efdc`_$LT$datafusion_optimizer..push_down_filter..PushDownFilter$u20$as$u20$datafusion_optimizer..optimizer..OptimizerRule$GT$::try_optimize::hcc5af41853d9aa51 at push_down_filter.rs:745:17 frame #7: 0x0000000100705367 tpcds_planning-c781740f1011efdc`datafusion_optimizer::utils::optimize_children::h54aa06b4ed6a900f at utils.rs:48:25 frame #8: 0x00000001006bf761 tpcds_planning-c781740f1011efdc`_$LT$datafusion_optimizer..push_down_filter..PushDownFilter$u20$as$u20$datafusion_optimizer..optimizer..OptimizerRule$GT$::try_optimize::hcc5af41853d9aa51 at push_down_filter.rs:745:17 frame #9: 0x0000000100705367 tpcds_planning-c781740f1011efdc`datafusion_optimizer::utils::optimize_children::h54aa06b4ed6a900f at utils.rs:48:25 frame #10: 0x00000001006bf000 tpcds_planning-c781740f1011efdc`_$LT$datafusion_optimizer..push_down_filter..PushDownFilter$u20$as$u20$datafusion_optimizer..optimizer..OptimizerRule$GT$::try_optimize::hcc5af41853d9aa51 at push_down_filter.rs:535:33 frame #11: 0x0000000100705367 tpcds_planning-c781740f1011efdc`datafusion_optimizer::utils::optimize_children::h54aa06b4ed6a900f at utils.rs:48:25 frame #12: 0x00000001006bf000 tpcds_planning-c781740f1011efdc`_$LT$datafusion_optimizer..push_down_filter..PushDownFilter$u20$as$u20$datafusion_optimizer..optimizer..OptimizerRule$GT$::try_optimize::hcc5af41853d9aa51 at push_down_filter.rs:535:33 frame #13: 0x0000000100705367 tpcds_planning-c781740f1011efdc`datafusion_optimizer::utils::optimize_children::h54aa06b4ed6a900f at utils.rs:48:25 frame #14: 0x00000001006bf000 tpcds_planning-c781740f1011efdc`_$LT$datafusion_optimizer..push_down_filter..PushDownFilter$u20$as$u20$datafusion_optimizer..optimizer..OptimizerRule$GT$::try_optimize::hcc5af41853d9aa51 at push_down_filter.rs:535:33 frame #15: 0x0000000100705367 tpcds_planning-c781740f1011efdc`datafusion_optimizer::utils::optimize_children::h54aa06b4ed6a900f at utils.rs:48:25 frame #16: 0x00000001006bf000 tpcds_planning-c781740f1011efdc`_$LT$datafusion_optimizer..push_down_filter..PushDownFilter$u20$as$u20$datafusion_optimizer..optimizer..OptimizerRule$GT$::try_optimize::hcc5af41853d9aa51 at push_down_filter.rs:535:33 ...``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
