liukun4515 commented on code in PR #4742:
URL: https://github.com/apache/arrow-datafusion/pull/4742#discussion_r1059917975
##########
datafusion/core/src/physical_plan/file_format/parquet/page_filter.rs:
##########
@@ -381,15 +381,28 @@ macro_rules! get_min_max_values_for_page_index {
vec.iter().map(|x| x.$func().cloned()),
)))
}
- Index::BYTE_ARRAY(index) => {
- let vec = &index.indexes;
- let array: StringArray = vec
- .iter()
- .map(|x| x.$func())
- .map(|x| x.and_then(|x| std::str::from_utf8(x).ok()))
- .collect();
- Some(Arc::new(array))
- }
+ Index::BYTE_ARRAY(index) => match $self.target_type {
Review Comment:
No, because there is no UT for the the `page filter`, but I can add some
test cases in the follow up pr for the page filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
