alamb commented on code in PR #3427:
URL: https://github.com/apache/arrow-rs/pull/3427#discussion_r1060041637
##########
arrow-integration-testing/tests/ipc_reader.rs:
##########
@@ -102,163 +95,119 @@ fn read_generated_be_files_should_work() {
.unwrap();
FileReader::try_new(file, None).unwrap();
+
+ // While the the reader doesn't error but the values are not read
correctly
+ // so verifing the contents fails
+ //verify_arrow_file(&testdata, "1.0.0-bigendian", path);
});
}
#[test]
-fn projection_should_work() {
- // complementary to the previous test
+fn read_1_0_0_littleendian() {
let testdata = arrow_test_data();
+ let version = "1.0.0-littleendian";
let paths = vec![
- "generated_interval",
"generated_datetime",
+ "generated_custom_metadata",
+ "generated_decimal",
+ "generated_decimal256",
+ "generated_dictionary",
+ "generated_dictionary_unsigned",
+ "generated_duplicate_fieldnames",
+ "generated_extension",
+ "generated_interval",
"generated_map",
+ // fails with
+ // thread 'read_1_0_0_littleendian' panicked at 'assertion failed:
`(left == right)`
+ //"generated_map_non_canonical",
"generated_nested",
- "generated_null_trivial",
+ "generated_nested_dictionary",
+ "generated_nested_large_offsets",
"generated_null",
+ "generated_null_trivial",
+ "generated_primitive",
+ "generated_primitive_large_offsets",
"generated_primitive_no_batches",
"generated_primitive_zerolength",
- "generated_primitive",
+ "generated_recursive_nested",
+ "generated_union",
];
paths.iter().for_each(|path| {
- // We must use littleendian files here.
- // The offsets are not translated for big-endian files
- // https://github.com/apache/arrow-rs/issues/859
- let file = File::open(format!(
- "{}/arrow-ipc-stream/integration/1.0.0-littleendian/{}.arrow_file",
- testdata, path
- ))
- .unwrap();
-
- let reader = FileReader::try_new(file, Some(vec![0])).unwrap();
- let datatype_0 = reader.schema().fields()[0].data_type().clone();
- reader.for_each(|batch| {
- let batch = batch.unwrap();
- assert_eq!(batch.columns().len(), 1);
- assert_eq!(datatype_0,
batch.schema().fields()[0].data_type().clone());
- });
+ verify_arrow_file(&testdata, version, path);
+ verify_arrow_stream(&testdata, version, path);
});
}
#[test]
-fn read_generated_streams_014() {
Review Comment:
the stream tests have been incorporated into the same test as the file tests
(so I didn't have to audit two separate lists of files)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
