jimhester edited a comment on pull request #8365: URL: https://github.com/apache/arrow/pull/8365#issuecomment-718020238
Oh hmm, it is not on purpose, I think it was just copy pasted from the `const char*` implementation above. We should use `mkCharLenCE` for `std::string()` since we know the length. That being said having an embedded `NULL` in any `CHARSXP` is not really going to work in R. Lots of places in the R codebase assumes strings are null terminated. I think the only way you can handle string data with embedded nulls in R is with raw vectors. Which erroring maybe is the intent here, so perhaps switching this to `mkCharLenCE` will do what we want. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
