andygrove commented on code in PR #115:
URL: 
https://github.com/apache/arrow-datafusion-python/pull/115#discussion_r1060180273


##########
src/dataframe.rs:
##########
@@ -38,8 +38,8 @@ pub(crate) struct PyDataFrame {
 
 impl PyDataFrame {
     /// creates a new PyDataFrame
-    pub fn new(df: Arc<DataFrame>) -> Self {
-        Self { df }
+    pub fn new(df: DataFrame) -> Self {
+        Self { df: Arc::new(df) }

Review Comment:
   Pyo3 methods require `&self` and cannot take `self`, so my solution was to 
introduce an `Arc` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to