tustvold commented on PR #3429: URL: https://github.com/apache/arrow-rs/pull/3429#issuecomment-1369664724
> Is there perhaps some subset of the options we could expose, perhaps the same subset as exposed by from_env > that allow for configuration based on "well-known-keys" that may also be in the environment. > key-value-like configs There appears to be consensus on this being the path forward, having an explicit config interface makes sense to me, over serializing the builders directly. I also agree that being able to "hydrate" from an arbitrary list of key value pairs, is a compelling interface. I think the major challenge with such an interface is documenting it well, as you don't have the benefit of the compiler / rustdoc to do the heavy lifting for you, but that is certainly not insurmountable. > fn from_kv(cfg: &HashMap<String, String>) -> Self Or even a `fn with_option(self, key: &str, value: &str) -> Result<Self>` or something, no need to constrain to being a `HashMap` > If there is general interest already I'd be happy to open a PR for a more concrete discussion That would be amazing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
