pitrou commented on code in PR #15124:
URL: https://github.com/apache/arrow/pull/15124#discussion_r1060501041
##########
cpp/src/parquet/encoding.cc:
##########
@@ -2479,7 +2481,18 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual
public TypedDecoder<DTyp
if (ARROW_PREDICT_FALSE(values_current_mini_block_ == 0)) {
if (ARROW_PREDICT_FALSE(!block_initialized_)) {
buffer[i++] = last_value_;
- if (ARROW_PREDICT_FALSE(i == max_values)) break;
+ if (ARROW_PREDICT_FALSE(i == max_values)) {
Review Comment:
Perhaps add this check
```suggestion
DCHECK_EQ(i, 1); // we're at the beginning of the page
if (ARROW_PREDICT_FALSE(i == max_values)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
