jackwener commented on PR #4802: URL: https://github.com/apache/arrow-datafusion/pull/4802#issuecomment-1369877140
> These tests are really to check that subqueries get rewritten as joins rather than being about tpch. The change in the test here just checks for correct results and does not check the details of how the plans are rewritten, so I feel like we are losing some value with this change. However, we also check for expected plans in tpch so maybe this is fine. Would be good to check with @avantgardnerio who originally implemented these tests, or @iajoiner. But these test already exist, they are same with tpch-test. like - https://github.com/apache/arrow-datafusion/blob/master/benchmarks/expected-plans/q2.txt - https://github.com/apache/arrow-datafusion/blob/master/benchmarks/expected-plans/q4.txt - https://github.com/apache/arrow-datafusion/blob/master/benchmarks/expected-plans/q17.txt - https://github.com/apache/arrow-datafusion/blob/master/benchmarks/expected-plans/q20.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
