ByteBaker opened a new pull request, #3437: URL: https://github.com/apache/arrow-rs/pull/3437
- Use signed integers to store 'Date', 'TimestampMillis' and 'TimestampMicros' in 'enum Field' - remove timezone from string representation of Date # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #3430 . # Rationale for this change The `Field` type in `parquet::record` interpreted Date/Time values as unsigned integers, representing number of seconds from Unix epoch. This was wrong because values before epoch do exist. When encountered with a `Row` that contains such a value, calling `to_json_value` panicked. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? This commit changes the implementation of `Field` to now use signed integers to read timestamp. It also removes timezone from the string representation of `Field::Date`, which made no sense otherwise. # Are there any user-facing changes? None. All test cases pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
