wjones127 commented on code in PR #15101:
URL: https://github.com/apache/arrow/pull/15101#discussion_r1060930315
##########
cpp/src/parquet/arrow/reader_writer_benchmark.cc:
##########
@@ -197,6 +197,52 @@ BENCHMARK_TEMPLATE2(BM_WriteColumn, true, DoubleType);
BENCHMARK_TEMPLATE2(BM_WriteColumn, false, BooleanType);
BENCHMARK_TEMPLATE2(BM_WriteColumn, true, BooleanType);
+int32_t kInfiniteUniqueValues = -1;
+
+std::shared_ptr<::arrow::Table> RandomStringTable(int64_t length, int64_t
unique_values,
+ int64_t null_percentage) {
+ std::shared_ptr<::arrow::DataType> type = ::arrow::utf8();
+ std::shared_ptr<::arrow::Array> arr;
+ ::arrow::random::RandomArrayGenerator generator(500);
Review Comment:
Yeah, the same seed is hardcoded elsewhere in the file. Is there somewhere
we should be taking the seed from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
