alamb commented on code in PR #3417:
URL: https://github.com/apache/arrow-rs/pull/3417#discussion_r1060931120
##########
arrow-csv/src/writer.rs:
##########
@@ -400,30 +272,6 @@ impl WriterBuilder {
self
}
- /// Set the CSV file's date format
Review Comment:
Presumably since someone added these functions previously they were being
used 🤔 On the other hand, given they aren't passed to the actual writer and
the code was marked as dead maybe they were silently ignored
##########
arrow-csv/src/writer.rs:
##########
@@ -95,18 +89,6 @@ pub struct Writer<W: Write> {
writer: csv::Writer<W>,
/// Whether file should be written with headers. Defaults to `true`
has_headers: bool,
- /// The date format for date arrays
- date_format: String,
- /// The datetime format for datetime arrays
- datetime_format: String,
- /// The timestamp format for timestamp arrays
- #[allow(dead_code)]
Review Comment:
🤔 the dead code is certainly suspicious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
