alamb commented on code in PR #4803:
URL: https://github.com/apache/arrow-datafusion/pull/4803#discussion_r1060938164
##########
datafusion/optimizer/src/filter_null_join_keys.rs:
##########
@@ -43,8 +43,12 @@ impl OptimizerRule for FilterNullJoinKeys {
fn try_optimize(
&self,
plan: &LogicalPlan,
- _config: &dyn OptimizerConfig,
+ config: &dyn OptimizerConfig,
) -> Result<Option<LogicalPlan>> {
+ if !config.options().optimizer.filter_null_join_keys {
+ return Ok(None);
Review Comment:
maybe it is worth a `debug!` here if this is skipped
##########
datafusion/common/src/config.rs:
##########
@@ -17,7 +17,7 @@
//! DataFusion Configuration Options
-use datafusion_common::{DataFusionError, Result};
+use crate::{DataFusionError, Result};
Review Comment:
🎉
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -91,28 +85,25 @@ pub struct OptimizerContext {
/// Query execution start time that can be used to rewrite
/// expressions such as `now()` to use a literal value instead
query_execution_start_time: DateTime<Utc>,
Review Comment:
very nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
