unconsolable commented on code in PR #4792:
URL: https://github.com/apache/arrow-datafusion/pull/4792#discussion_r1061213238
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -2016,14 +2016,6 @@ mod tests {
col("c1").eq(bool_expr.clone()),
// u32 AND bool
col("c2").and(bool_expr),
- // utf8 LIKE u32
- col("c1").like(col("c2")),
- // utf8 NOT LIKE u32
- col("c1").not_like(col("c2")),
- // utf8 ILIKE u32
- col("c1").ilike(col("c2")),
- // utf8 NOT ILIKE u32
- col("c1").not_ilike(col("c2")),
Review Comment:
> - In `datafusion::physical_plan::planner::tests::errors()`, tests for
`like/ilike/not like/not ilike` are removed, as for `Expr::Like` and
`Expr::ILike`, `coerce_types` are not performed in `Expr::get_type`
>
>
https://github.com/apache/arrow-datafusion/blob/54ae4323a730a4a34c6b5f638e2083f0c3fe5dcc/datafusion/expr/src/expr_schema.rs#L128-L130
However, these kind of error will be checked in `TypeCoercionRewriter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
