alamb commented on code in PR #4810:
URL: https://github.com/apache/arrow-datafusion/pull/4810#discussion_r1061827948
##########
datafusion/core/src/physical_plan/file_format/parquet/row_groups.rs:
##########
@@ -475,10 +475,21 @@ mod tests {
// c1 > 5, this row group will not be included in the results.
vec![ParquetStatistics::int32(Some(10), Some(20), None, 0, false)],
);
+ let rgm3 = get_row_group_meta_data(
+ &schema_descr,
+ // [1, None]
+ // c1 > 5, this row group will not be included in the results.
Review Comment:
```suggestion
// c1 > 5, this row group can not be filtered out, so will be
included in the results.
```
##########
datafusion/core/src/physical_plan/file_format/parquet/row_groups.rs:
##########
@@ -528,15 +539,21 @@ mod tests {
// c1 > 5, this row group will not be included in the results.
vec![ParquetStatistics::int32(Some(0), Some(2), None, 0, false)],
);
+ let rgm4 = get_row_group_meta_data(
+ &schema_descr,
+ // [None, 2]
+ // c1 > 5, this row group will not be included in the results.
Review Comment:
```suggestion
// c1 > 5, this row group can not be filtered out, so will be
included in the results.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
