alamb opened a new issue, #3456:
URL: https://github.com/apache/arrow-rs/issues/3456

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   in a DataFusion PR: 
https://github.com/apache/arrow-datafusion/pull/4777#discussion_r1060646358
   
   We have code that has `Vec<&RecordBatch>` (not `Vec<RecordBatch>`) and thus 
we can't call `concat_batches` as that requires taking ownership. I looked at 
the code for `concat_batches` and it is not at all clear why it needs ownership 
of the RecordBatch
   
   https://docs.rs/arrow/30.0.0/arrow/compute/fn.concat_batches.html
   
   
   **Describe the solution you'd like**
   I would like some way to call `concat_batches` that doesn't require an bunch 
of owned RecordBatches
   
   Perhaps something like this would work:
   
   ```rust
   pub fn concat_batches(
       schema: &Arc<Schema>,
       batches: impl IntoIter<Item = &RecordBatch>
   ) -> Result<RecordBatch, ArrowError>
   ```
   
   And existing callers could call concat_batches(&batches)
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to