jrevels commented on issue #367:
URL: https://github.com/apache/arrow-julia/issues/367#issuecomment-1371451140
> Our timestamp implementation of Timestamp{U, TZ} where U is the unit
precision and TZ is the name of the time zone is very closely aligned to the
pyarrow implementation:
Hmm. I'm still not sure we couldn't just choose to represent the direct
Arrow type in Julia as `Timestamp{U}(timezone::String)`. I guess it depends on
how Arrow.jl defines the mapping between flatbuffers-specified types and their
Julia type counterparts. I haven't dug into that part of the code in a while.
If that mapping is strictly defined in some generic sense, I guess we'd have to
follow that scheme, but if there's some leeway, it naively seems like
`Timestamp{U}(timezone::String)` would be a better representation on the Julia
front. also unsure how often Arrow.jl internally might rely on propagating
knowledge about arrow table schemas purely via the Julia "type domain" vs. the
Julia "value domain", but I guess that also factors in as well
> as we cannot support multiple time zones within the same vector.
i think part of the point is that we maybe CAN support this even with the
current type arrangement (unless i'm missing something), we'd just have to deal
with union types appropriately in a lot of places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
