tustvold commented on code in PR #3431:
URL: https://github.com/apache/arrow-rs/pull/3431#discussion_r1062189222
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -135,8 +143,40 @@ impl<W: Write> ArrowWriter<W> {
));
}
- for (buffer, column) in self.buffer.iter_mut().zip(batch.columns()) {
- buffer.push_back(column.clone())
+ for ((buffer, column), parquet_field) in self
+ .buffer
+ .iter_mut()
+ .zip(batch.columns())
+ .zip(&self.parquet_fields)
+ {
+ match column.data_type() {
+ // if the arrow data type is decimal
+ ArrowDataType::Decimal128(_, _) => {
Review Comment:
I think this logic should be moved to write_leaf where we have other
coercion logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
