lidavidm commented on code in PR #289:
URL: https://github.com/apache/arrow-cookbook/pull/289#discussion_r1062465382


##########
java/source/io.rst:
##########
@@ -320,6 +320,65 @@ We are providing a path with auto generated arrow files 
for testing purposes, ch
    Jhon    29
    Thomy    33
 
+Read - From Compressed File
+---------------------------
+
+We are providing a path with auto generated arrow files for testing purposes, 
change that at your convenience.
+
+Compressed file generated through this code example:
+
+.. code:: python
+
+   import pandas as pd
+   import pyarrow as pa
+
+   pd.DataFrame({'key': range(4)}).to_feather('lz4.arrow', compression='lz4')
+   pd.DataFrame({'key': range(4)}).to_feather('zstd.arrow', compression='zstd')
+
+.. note::
+
+   Java Vector module offer read files without compression codec, in case 
reading
+   compressed files is required consider to also add Java Compression module
+   dependency.

Review Comment:
   ```suggestion
      The ``arrow-vector`` module can only read uncompressed files by itself.  
Add
      a dependency on ``arrow-compression`` to also be able to read compressed 
files.
   ```



##########
java/source/io.rst:
##########
@@ -320,6 +320,65 @@ We are providing a path with auto generated arrow files 
for testing purposes, ch
    Jhon    29
    Thomy    33
 
+Read - From Compressed File
+---------------------------
+
+We are providing a path with auto generated arrow files for testing purposes, 
change that at your convenience.
+
+Compressed file generated through this code example:
+
+.. code:: python
+
+   import pandas as pd
+   import pyarrow as pa
+
+   pd.DataFrame({'key': range(4)}).to_feather('lz4.arrow', compression='lz4')
+   pd.DataFrame({'key': range(4)}).to_feather('zstd.arrow', compression='zstd')

Review Comment:
   This isn't checked in?



##########
java/source/io.rst:
##########
@@ -320,6 +320,65 @@ We are providing a path with auto generated arrow files 
for testing purposes, ch
    Jhon    29
    Thomy    33
 
+Read - From Compressed File
+---------------------------
+
+We are providing a path with auto generated arrow files for testing purposes, 
change that at your convenience.

Review Comment:
   Is it possible to provide a write-compressed-file example too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to