alamb commented on code in PR #3464:
URL: https://github.com/apache/arrow-rs/pull/3464#discussion_r1062808129


##########
arrow-flight/src/client.rs:
##########
@@ -531,3 +549,142 @@ impl FlightClient {
         request
     }
 }
+
+// splits the input stream  into an invallable flight data stream and errors 
errors
+//
+// TODO generify
+fn split_stream(

Review Comment:
   > Yea, as I commented previously, I'm not sure if it makes sense to put 
incomplete input stream for the valid ones. I guess that if any error in the 
input stream, it should not do put.
   
   I guess what I was thinking was that in order to know if there will be an 
error in the input stream, I think it needs to be read (buffered) entirely 
prior to making a request to the server.
   
   I thought what was desired was to allow the client to make  a request 
*without* buffering the entire input stream 🤔 
   
   I think I am missing something



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to