alamb commented on code in PR #4778:
URL: https://github.com/apache/arrow-datafusion/pull/4778#discussion_r1062838433
##########
datafusion/core/src/dataframe.rs:
##########
@@ -766,9 +775,12 @@ impl DataFrame {
}
}
-// TODO: This will introduce a ref cycle (#2659)
+struct DataFrameTableProvider {
+ plan: LogicalPlan,
+}
+
#[async_trait]
-impl TableProvider for DataFrame {
+impl TableProvider for DataFrameTableProvider {
Review Comment:
~Where is the ref cycle that this change fixing? I think I am missing
something here~
I see the cycle happens when the dataframe is registered as a table provider
on the same context
I think this makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
