viirya commented on code in PR #3466:
URL: https://github.com/apache/arrow-rs/pull/3466#discussion_r1062880329
##########
arrow-ord/src/ord.rs:
##########
@@ -263,6 +263,73 @@ pub fn build_compare(
UInt16 => cmp_dict_primitive::<UInt16Type>(key_type_lhs, left,
right)?,
UInt32 => cmp_dict_primitive::<UInt32Type>(key_type_lhs, left,
right)?,
UInt64 => cmp_dict_primitive::<UInt64Type>(key_type_lhs, left,
right)?,
+ Float32 => cmp_dict_primitive::<Float32Type>(key_type_lhs,
left, right)?,
+ Float64 => cmp_dict_primitive::<Float64Type>(key_type_lhs,
left, right)?,
+ Date32 => cmp_dict_primitive::<Date32Type>(key_type_lhs, left,
right)?,
+ Date64 => cmp_dict_primitive::<Date64Type>(key_type_lhs, left,
right)?,
+ Time32(Second) => {
+ cmp_dict_primitive::<Time32SecondType>(key_type_lhs, left,
right)?
+ }
+ Time32(Millisecond) =>
cmp_dict_primitive::<Time32MillisecondType>(
+ key_type_lhs,
+ left,
+ right,
+ )?,
+ Time64(Microsecond) =>
cmp_dict_primitive::<Time64MicrosecondType>(
+ key_type_lhs,
+ left,
+ right,
+ )?,
+ Time64(Nanosecond) => {
+ cmp_dict_primitive::<Time64NanosecondType>(key_type_lhs,
left, right)?
+ }
+ Timestamp(Second, _) => {
+ cmp_dict_primitive::<TimestampSecondType>(key_type_lhs,
left, right)?
+ }
+ Timestamp(Millisecond, _) => cmp_dict_primitive::<
+ TimestampMillisecondType,
+ >(key_type_lhs, left, right)?,
+ Timestamp(Microsecond, _) => cmp_dict_primitive::<
+ TimestampMicrosecondType,
+ >(key_type_lhs, left, right)?,
+ Timestamp(Nanosecond, _) => {
+ cmp_dict_primitive::<TimestampNanosecondType>(
+ key_type_lhs,
+ left,
+ right,
+ )?
+ }
+ Interval(YearMonth) =>
cmp_dict_primitive::<IntervalYearMonthType>(
+ key_type_lhs,
+ left,
+ right,
+ )?,
+ Interval(DayTime) => {
+ cmp_dict_primitive::<IntervalDayTimeType>(key_type_lhs,
left, right)?
+ }
+ Interval(MonthDayNano) =>
cmp_dict_primitive::<IntervalMonthDayNanoType>(
+ key_type_lhs,
+ left,
+ right,
+ )?,
+ Duration(Second) => {
+ cmp_dict_primitive::<DurationSecondType>(key_type_lhs,
left, right)?
+ }
+ Duration(Millisecond) =>
cmp_dict_primitive::<DurationMillisecondType>(
+ key_type_lhs,
+ left,
+ right,
+ )?,
+ Duration(Microsecond) =>
cmp_dict_primitive::<DurationMicrosecondType>(
+ key_type_lhs,
+ left,
+ right,
+ )?,
+ Duration(Nanosecond) =>
cmp_dict_primitive::<DurationNanosecondType>(
+ key_type_lhs,
+ left,
+ right,
+ )?,
Review Comment:
I leave decimal type out here and will do it in other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
