jonmmease opened a new pull request, #3473: URL: https://github.com/apache/arrow-rs/pull/3473
# Which issue does this PR close? Closes #3471. # What changes are included in this PR? 74bad75429f52cda53f66a2b4a794ec6d56ef5ff update the `test_take_slice_string` test to include an extra empty list element. This fails on its own as the empty list is converted to a `null` in `take` 290d6cca64c89b415abe52c279ec903f888c9568 and b01f9e59d1c15fcc757adf4569a936594a7b449b fix the null buffer for the input data in `test_take_list_with_nulls` and `test_take_list_with_value_nulls` respectively. The previous implementation of `take` for lists actually ignores the null mask of the input list array, so my guess is that it why it wasn't noticed that these masks don't match the intended arrays expressed in the surrounding comments. Without these fixes the change below causes these tests to fail, but I think that's expected given the null masks that were previously provided. 2ff14fa4cda8e77fd4c23b2f9951f437225b74d5 moves the calculation of the null buffer into `take_value_indices_from_list` where we have access to the null info of both the indices and list array. # Are there any user-facing changes? This is a bug fix, but could be considered breaking as it's been around for a while and downstream code has likely adapted to the behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
