wjones127 commented on code in PR #15213:
URL: https://github.com/apache/arrow/pull/15213#discussion_r1063568116
##########
cpp/src/arrow/adapters/orc/adapter_test.cc:
##########
@@ -536,6 +536,15 @@ TEST_F(TestORCWriterTrivialNoConversion,
writeFilledChunkAndSelectField) {
&selected_indices);
}
+TEST_F(TestORCWriterTrivialNoConversion, writeSlicedBatch) {
+ std::shared_ptr<Table> table =
+ GenerateRandomTable(table_schema, /*size=*/100, /*min_num_chunks=*/1,
Review Comment:
The test doesn't cover that case. But it should be fine, since
`NormalizeArray` is recursive. So `NormalizeArray(list<list<X>>)` calls
`NormalizeArray(list<X>)`, which calls `NormalizeArray(X)`. The offsets at each
level should be handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
