mapleFU opened a new pull request, #15238:
URL: https://github.com/apache/arrow/pull/15238
Here I change const char* to std::string_view, because:
1. `Unreachable(std::string(" a") + "b")` all
`Unreachable(fmt::format(...))` could be easily used
2. non-c-style string can be used.
The cons maybe:
1. abi broken ( Seems no one will use Unreachable like this?)
2. Maybe making compiling a bit slower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
