jorgecarleitao commented on a change in pull request #8567:
URL: https://github.com/apache/arrow/pull/8567#discussion_r516159690
##########
File path: .github/workflows/rust.yml
##########
@@ -68,7 +68,7 @@ jobs:
uses: actions/cache@v1
with:
path: .docker
- key: debian-10-rust-${{ hashFiles('rust/**.rs') }}
+ key: debian-10-rust-${{ hashFiles('rust/**/**.rs',
'rust/**/Cargo.toml') }}
Review comment:
Without this, `hashFiles` becomes an empty string.
##########
File path: .github/workflows/rust.yml
##########
@@ -118,8 +118,8 @@ jobs:
uses: actions/cache@v1
with:
path: rust/target
- key: windows-rust-${{ hashFiles('rust/**.rs') }}
- restore-keys: windows-rust-
+ key: windows-rust-v1-${{ hashFiles('rust/**/**.rs',
'rust/**/Cargo.toml') }}
Review comment:
yes, purely for that. Maybe there is a way to address this in another
way, I was unable to make it work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
